Conversation
oschwald
force-pushed
the
greg/eng-3367
branch
5 times, most recently
from
312b9f4 to
18f9152
Compare
This adds a GitHub Actions workflow that runs on PRs to detect breaking changes in the public API. The check uses japicmp with semantic versioning support, so it will only fail if breaking changes are detected without a major version bump. ENG-3367 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-3367
branch
from
18f9152 to
7ce1695
Compare
oschwald
commented
Jan 12, 2026
| perl -pi -e "s/(?<=<version>)[^<]*/$version/" README.md | ||
| perl -pi -e "s/(?<=com\.maxmind\.geoip2\:geoip2\:)\d+\.\d+\.\d+([\w\-]+)?/$version/" README.md | ||
|
|
||
| # Update japicmp.baselineVersion for API compatibility checking |
Member
Author
There was a problem hiding this comment.
Although japicmp has functionality to compare the current version to the previous version, this does not work if we have not yet bumped the version number for a release.
horgh
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api-compat.yml) that runs on PRs to detect breaking changes in the public APIaccessModifier=public)Test plan
ENG-3367
🤖 Generated with Claude Code